Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pbs): stateless pbs module #212

Merged
merged 2 commits into from
Dec 18, 2024
Merged

feat(pbs): stateless pbs module #212

merged 2 commits into from
Dec 18, 2024

Conversation

ltitanb
Copy link
Collaborator

@ltitanb ltitanb commented Dec 16, 2024

fix #61

Transition the default PBS module to a fully stateless setup. In practice this means we lose:

  • the X-MEVBoost-SlotID header that linked getHeader/getPayload calls
  • logs on missed payload of all relays that delivered the header but not the paylod (this is still accessible from previous logs or via the relay data API)

In exchange we get a cleaner and more scalable setup, see also the discussions in #61 and CC2

After this the PbsState is effectively just a wrapper for the config plus any state stored by modules that is left for now to avoid breaking anything downstream. We should evaluate separately if this should warrant a redesign of PBS custom modules

Copy link
Collaborator

@ManuelBilbao ManuelBilbao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ltitanb ltitanb merged commit 895aa20 into main Dec 18, 2024
4 checks passed
@ltitanb ltitanb deleted the ltitanb/stateless-pbs branch December 18, 2024 10:17
ltitanb added a commit that referenced this pull request Jan 10, 2025
@estensen
Copy link

@ManuelBilbao @ltitanb in the future, could you please label breaking changes like this in the release notes? Bolt depends on some public functions that are being removed here.

@ltitanb
Copy link
Collaborator Author

ltitanb commented Jan 16, 2025

Noted @estensen , apologies for the oversight!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider a stateless design on the PBS module
3 participants