-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(signer): add ERC2335 ProxyStore #193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While trying the full flow using the example in da_commit
i get an error error: error sending request for url (http://127.0.0.1:20000/signer/v1/generate_proxy_key)
although the request is received from the server.
I've also noticed that loading the keys is quite slow when running locally, so maybe we should add a /status
endpoint in the signer server and wait on that when starting the other modules in the docker compose. This can also be used to add a health check in the container
Added a healthcheck on docker compose so singer-dependant modules don't start until signer is healthy |
This PR implements a new way to safely store proxy keys using ERC-2335 format. It saves (and reads) the keys and secrets using the following structure:
Storing in the
.sig
file the delegation signatureClose #71