Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support environment variables in module config #115

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

mempirate
Copy link

Closes #110

@mempirate mempirate marked this pull request as ready for review September 11, 2024 12:34
@ltitanb
Copy link
Collaborator

ltitanb commented Sep 11, 2024

Looks good! There's a test failing, should just be re-ordering the args in the example config so that they dont get parsed inside the HashMap<String, String>

@mempirate
Copy link
Author

Ah missed that sorry! Resolved in latest commit

@ltitanb ltitanb merged commit aed00e8 into Commit-Boost:main Sep 12, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module configuration: support env variables
2 participants