Preview 1.82.18 Hotfix #690

bagusnl · 2025-02-16T17:53:54Z

What's changed? - 1.82.18

[Fix] Launcher crashing when the main game thread unexpectedly closes, by @neon-nyan
[Fix] Taskbar progress not reset after game install/update, by @shatyuka
[Fix] Ensures temporary files availability, by @neon-nyan
[Fix] 7z COMException errors, by @neon-nyan
[Fix] Genshin's repair missing a few files, by @neon-nyan

Templates

Changelog Prefixes

  **[New]**
  **[Imp]**
  **[Fix]**
  **[Loc]**
  **[Doc]**

100% reviewed source file: 'en_US.json' on 'id_ID'.

100% reviewed source file: 'en_US.json' on 'ja_JP'.

again and again

"Eternal"? "External"? idk....

+ This ended up refactoring the whole fetch and check mechanism

github-actions · 2025-02-16T18:11:18Z

Qodana for .NET

10 new problems were found

Inspection name	Severity	Problems
`Possible 'System.NullReferenceException'`	🔶 Warning	4
`Possible null reference argument for a parameter.`	🔶 Warning	2
`Unused local variable`	🔶 Warning	2
`Conditional access qualifier expression is not null according to nullable reference types' annotations`	🔶 Warning	1
`Non-accessed positional property (non-private accessibility)`	🔶 Warning	1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

CollapseLauncher/Classes/RepairManagement/Genshin/Fetch.cs

+                // If the ignoreContainsParams is not null and the remoteName contains
+                // ignore list, then move to another entry
+                if (ignoreContainsParams != null &&
+                    manifestEntry.remoteName


CollapseLauncher/Classes/RepairManagement/Genshin/Fetch.cs

+                }
+
+                // Resolve the svc_catalog name where the localName contains "../"
+                if (manifestEntry.remoteName.EndsWith("svc_catalog"))


CollapseLauncher/Classes/RepairManagement/Genshin/Fetch.cs

-                {
-                    entry!.remoteName = $"{parentPath.Replace('\\', '/')}/{entry.remoteName}";
-                }
+                string relativeParentPath = string.IsNullOrEmpty(parentPath) ? "" : GetParentFromAssetRelativePath(entry.remoteName, out _);


CollapseLauncher/Classes/RepairManagement/Genshin/Fetch.cs

-                    entry!.remoteName = $"{parentPath.Replace('\\', '/')}/{entry.remoteName}";
-                }
+                string relativeParentPath = string.IsNullOrEmpty(parentPath) ? "" : GetParentFromAssetRelativePath(entry.remoteName, out _);
+                entry.remoteName = Path.Combine(parentPath ?? "", relativeParentPath, entry.remoteName);


Cryotechnic · 2025-02-19T02:43:49Z

Approved via VC

sonarqubecloud · 2025-02-19T02:46:47Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Cryotechnic and others added 19 commits February 10, 2025 00:10

[skip ci] Update README.md

cc85068

[skip ci] Sync translation Translate en_US.json in id_ID

82532f1

100% reviewed source file: 'en_US.json' on 'id_ID'.

[CI] [VT] Grant permission

779a79d

[skip ci] Update README.md

db546e4

[skip ci] Sync translation Translate en_US.json in ja_JP

26ad6b0

100% reviewed source file: 'en_US.json' on 'ja_JP'.

Fix hardcrash while awaiting Process on exit

e759c43

Fix taskbar progress does not disappear after game installation

4e1c977

again and again

Use explicit dotnet version

1844be6

[skip ci][CI][QD] Fix dotnet versioning

a31c54f

[skip ci][CI][QD] Fix dotnet versioning

4f36862

[Sophon] Always ensure temp file availability

749db3f

[GenshinRepair] Tidy-up parent path lookup

b8d9035

[7-zip] Fix potential Class not registered error

49be7b4

[GenshinRepair] Re-route res_versions_external to res_versions_persist

f395029

[GenshinRepair] Ignore IFix remote blocks

0a08078

[GenshinRepair] Store res_revision_eternal

690fa0c

"Eternal"? "External"? idk....

[GenshinRepair] Save PatchDone content

c1ff034

[GenshinRepair] Fix attempt for missing files

5cb49f0

+ This ended up refactoring the whole fetch and check mechanism

Increase isLongRunning param on hasher to 1 GB

02afb52

github-advanced-security bot found potential problems Feb 16, 2025

View reviewed changes

neon-nyan and others added 2 commits February 18, 2025 00:05

Fix zip uncompress size calc always relies on 7-zip

9423e57

Bump version

dd37df8

Cryotechnic merged commit cddd41b into preview Feb 19, 2025
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Preview 1.82.18 Hotfix #690

Preview 1.82.18 Hotfix #690

bagusnl commented Feb 16, 2025

github-actions bot commented Feb 16, 2025 •

edited

Loading

Cryotechnic commented Feb 19, 2025

sonarqubecloud bot commented Feb 19, 2025

Preview 1.82.18 Hotfix #690

Preview 1.82.18 Hotfix #690

Conversation

bagusnl commented Feb 16, 2025

What's changed? - 1.82.18

Templates

github-actions bot commented Feb 16, 2025 • edited Loading

Qodana for .NET

Cryotechnic commented Feb 19, 2025

sonarqubecloud bot commented Feb 19, 2025

Quality Gate passed

github-actions bot commented Feb 16, 2025 •

edited

Loading