Ignore: ✏️ Append WHERE condition in readNotification Query

[psychology50]

작업 이유

• We had three types of notices, but the designer wants to display only Announce type notifications.

작업 사항

@Transactional(readOnly = true)
public Slice<Notification> readNotificationsSlice(Long userId, Pageable pageable, NoticeType noticeType) {
    Predicate predicate = notification.receiver.id.eq(userId)
            .and(notification.readAt.isNotNull())
            .and(notification.type.eq(noticeType));

    QueryHandler queryHandler = query -> query
            .offset(pageable.getOffset())
            .limit(pageable.getPageSize() + 1);

    Sort sort = pageable.getSort();

    return SliceUtil.toSlice(notificationRepository.findList(predicate, queryHandler, sort), pageable);
}

@Transactional(readOnly = true)
public List<Notification> readUnreadNotifications(Long userId, NoticeType noticeType) {
    Predicate predicate = notification.receiver.id.eq(userId)
            .and(notification.readAt.isNull())
            .and(notification.type.eq(noticeType));

    return notificationRepository.findList(predicate, null, null);
}

• Add a NoticeType parameter to the domain service’s read method.

리뷰어가 중점적으로 확인해야 하는 부분

• none

발견한 이슈

• none