-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api: ✨ 채팅방 생성 API #173
Merged
Merged
Api: ✨ 채팅방 생성 API #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 이유
작업 사항
해당 UseCase는 2-Stage로 구성됩니다.
이렇게 되어야 하는 이유는 채팅방 이미지 S3 저장 경로 때문인데, 기존 플로우라면 다음과 같이 진행해야 마땅합니다.
그러나, 저희의 채팅방 이미지 경로에는
chat_room_id
가 포함되어 있습니다.즉, 클라이언트는 "채팅방을 생성한 후에 이미지를 저장 가능"하다는 모순에 빠지게 되었습니다.
이제 와서 경로를 수정하는 것은 작업을 너무 지연시킬 우려가 있기 때문에, 플로우를 다음과 같이 수정했습니다.
리뷰어가 중점적으로 확인해야 하는 부분
userId
를 key로 캐싱하기 때문에 데이터를 덮어쓰게 되므로 문제가 없습니다.발견한 이슈