-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch: ✏️ 매일 정기 푸시 알림 배치 성능 개선 #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...batch/src/main/java/kr/co/pennyway/batch/common/reader/QuerydslNoOffsetPagingItemReader.java
Show resolved
Hide resolved
pennyway-batch/src/main/java/kr/co/pennyway/batch/common/reader/QuerydslPagingItemReader.java
Show resolved
Hide resolved
pennyway-batch/src/main/java/kr/co/pennyway/batch/common/reader/expression/Expression.java
Show resolved
Hide resolved
pennyway-batch/src/main/java/kr/co/pennyway/batch/common/reader/expression/OrderExpression.java
Show resolved
Hide resolved
pennyway-batch/src/main/java/kr/co/pennyway/batch/common/reader/expression/WhereExpression.java
Show resolved
Hide resolved
...y-batch/src/main/java/kr/co/pennyway/batch/common/reader/expression/WhereNumberFunction.java
Show resolved
Hide resolved
...y-batch/src/main/java/kr/co/pennyway/batch/common/reader/expression/WhereStringFunction.java
Show resolved
Hide resolved
.../src/main/java/kr/co/pennyway/batch/common/reader/options/QuerydslNoOffsetNumberOptions.java
Show resolved
Hide resolved
...-batch/src/main/java/kr/co/pennyway/batch/common/reader/options/QuerydslNoOffsetOptions.java
Show resolved
Hide resolved
.../src/main/java/kr/co/pennyway/batch/common/reader/options/QuerydslNoOffsetStringOptions.java
Show resolved
Hide resolved
pennyway-batch/src/main/java/kr/co/pennyway/batch/job/DailySpendingNotifyConfig.java
Show resolved
Hide resolved
pennyway-batch/src/main/java/kr/co/pennyway/batch/reader/ActiveDeviceTokenReader.java
Show resolved
Hide resolved
pennyway-batch/src/main/java/kr/co/pennyway/batch/writer/NotificationWriter.java
Show resolved
Hide resolved
...ain/src/main/java/kr/co/pennyway/domain/domains/device/repository/DeviceTokenRepository.java
Show resolved
Hide resolved
.../kr/co/pennyway/domain/domains/notification/repository/NotificationCustomRepositoryImpl.java
Show resolved
Hide resolved
pennyway-domain/src/test/java/kr/co/pennyway/domain/common/redisson/CouponDecreaseLockTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 이유
작업 사항
1️⃣ 성능 측정 지표
2️⃣ QueryDsl no offset 방식의 커스텀 ItemReader
리뷰어가 중점적으로 확인해야 하는 부분
발견한 이슈
지금 당장 고려해야 할 만큼 중요한 이슈는 아니지만, 데이터 1억 개를 삽입하여 테스트 했을 시
초기 firstKey와 lastKey를 조회하는 쿼리가 심각한 성능 저하를 유발할 뿐만 아니라, 실행 시간이 너무 길어서 timeout이 나기도 함.
이는
QuerydslNoOffsetOptions
클래스 내부에서, Reader를 위한 쿼리를 기반으로min
,max
를 사용해 key를 구하려 하기 때문이라 생각. (join을 한 후, user.id로 min, max를 하기 때문에 index를 사용하지 못해 fullscan이 되어버림)따라서 firstKey, lastKey를 직접 할당하거나, key를 결정하기 위한 쿼리를 따로 제공할 수 있는 메서드를 추가하여 개선할 여지가 있음.