-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select All followed by Replace All sometimes causes infinite loop #16
Comments
@molsonkiko Step three in your instructions for replication confuses me. If you click in the document, the selection will be removed but the indicated region will be unchanged. To set the indicated region to the result of the Select All, you would need either to have clicked the Set button before you clicked anywhere in the document, or (with Auto set checked) proceeded to the next search without clicking inside the document. |
@molsonkiko Do you have any additional information? I can’t reproduce this. I don’t see the state you describe in step three unless I do something between steps two and three that you did not list (e.g., click the Set button; or repeat the Select All; or Count). Using Notepad++ 8.4.8 x64 and Columns++ 1.0, even with one of these additions, I’m not seeing a hang. I’d like to fix this, but I have no clue what to fix. |
Now that you mention it, I can't replicate this anymore when I try it again. I really have no idea what the differences would be. Possibly an interaction with the Hex Editor plugin that I uninstalled since then? In any case, here's my new debug info, now that I can't reproduce it anymore. I'm not going to close this myself, but you can if you want.
|
Closing as stale. We can reopen this if a way to reproduce it is found. Anyone else experiencing a similar problem should probably open a new issue. |
@molsonkiko I have stumbled across this bug myself, now, in an easily reproducible form:
This will hang Columns++ (and hence Notepad++). This is a serious bug, since a hang results in loss of unsaved changes in all open tabs. I believe I see the cause, and it appears to be a simple oversight on my part, so hopefully it won’t take long to post an updated version. |
…ular expression replace all/before/after decreases the length of the document. Addresses Issue #16 .
As shown below, this is on Columns++ v1 (not your newer v1.0.1).
To replicate:
\b\w{3}\b
(withSearch...
) to select all (the option under theCount
button) the three-char words.Search...
GUI)d
withxy
to attempt to convert all thed
chars in the selected text only intoxy
. Sometimes (again, I haven't had the time to diagnose exactly what causes it), this will cause an infinite loop and I will need to hard-shutdown NPP.In any case, the desired result of this process is the following:
Here's my debug info (I also have JsonTools, but I disabled it to test if it was involved in this, and it wasn't)
The text was updated successfully, but these errors were encountered: