Skip to content

Commit

Permalink
Add description and license / creator setting fields #794
Browse files Browse the repository at this point in the history
  • Loading branch information
girishpanchal30 committed May 5, 2021
1 parent 674bae8 commit 5a7d760
Show file tree
Hide file tree
Showing 4 changed files with 78 additions and 1 deletion.
14 changes: 14 additions & 0 deletions classes/Visualizer/Render/Sidebar/ChartJS.php
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,20 @@ protected function _renderGeneralSettings() {

$this->_renderAnimationSettings();

self::_renderSectionStart( esc_html__( 'License & Creator', 'visualizer' ), false );
self::_renderTextItem(
esc_html__( 'License', 'visualizer' ),
'license',
$this->license,
''
);
self::_renderTextItem(
esc_html__( 'Creator', 'visualizer' ),
'creator',
$this->creator,
''
);
self::_renderSectionEnd();
self::_renderGroupEnd();
}

Expand Down
22 changes: 22 additions & 0 deletions classes/Visualizer/Render/Sidebar/Type/GoogleCharts/Gauge.php
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,28 @@ protected function _renderGeneralSettings() {
$this->title,
esc_html__( 'Text to display in the back-end admin area.', 'visualizer' )
);

self::_renderTextAreaItem(
esc_html__( 'Chart Description', 'visualizer' ),
'description',
$this->description,
sprintf( esc_html__( 'Description to display in the structured data schema as explained %1$shere%2$s', 'visualizer' ), '<a href="https://developers.google.com/search/docs/data-types/dataset#dataset" target="_blank">', '</a>' )
);
self::_renderSectionEnd();

self::_renderSectionStart( esc_html__( 'License & Creator', 'visualizer' ), false );
self::_renderTextItem(
esc_html__( 'License', 'visualizer' ),
'license',
$this->license,
''
);
self::_renderTextItem(
esc_html__( 'Creator', 'visualizer' ),
'creator',
$this->creator,
''
);
self::_renderSectionEnd();

self::_renderGroupEnd();
Expand Down
21 changes: 21 additions & 0 deletions classes/Visualizer/Render/Sidebar/Type/GoogleCharts/Geo.php
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,27 @@ protected function _renderGeneralSettings() {
$this->title,
esc_html__( 'Text to display in the back-end admin area.', 'visualizer' )
);
self::_renderTextAreaItem(
esc_html__( 'Chart Description', 'visualizer' ),
'description',
$this->description,
sprintf( esc_html__( 'Description to display in the structured data schema as explained %1$shere%2$s', 'visualizer' ), '<a href="https://developers.google.com/search/docs/data-types/dataset#dataset" target="_blank">', '</a>' )
);
self::_renderSectionEnd();

self::_renderSectionStart( esc_html__( 'License & Creator', 'visualizer' ), false );
self::_renderTextItem(
esc_html__( 'License', 'visualizer' ),
'license',
$this->license,
''
);
self::_renderTextItem(
esc_html__( 'Creator', 'visualizer' ),
'creator',
$this->creator,
''
);
self::_renderSectionEnd();
self::_renderGroupEnd();
}
Expand Down
22 changes: 21 additions & 1 deletion classes/Visualizer/Render/Sidebar/Type/GoogleCharts/Tabular.php
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,28 @@ protected function _renderGeneralSettings() {
$this->title,
esc_html__( 'Text to display in the back-end admin area.', 'visualizer' )
);
self::_renderTextAreaItem(
esc_html__( 'Chart Description', 'visualizer' ),
'description',
$this->description,
sprintf( esc_html__( 'Description to display in the structured data schema as explained %1$shere%2$s', 'visualizer' ), '<a href="https://developers.google.com/search/docs/data-types/dataset#dataset" target="_blank">', '</a>' )
);
self::_renderSectionEnd();
self::_renderGroupEnd();

self::_renderSectionStart( esc_html__( 'License & Creator', 'visualizer' ), false );
self::_renderTextItem(
esc_html__( 'License', 'visualizer' ),
'license',
$this->license,
''
);
self::_renderTextItem(
esc_html__( 'Creator', 'visualizer' ),
'creator',
$this->creator,
''
);
self::_renderGroupEnd();
}

/**
Expand Down

0 comments on commit 5a7d760

Please sign in to comment.