Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icon alignment in DataIndicators #1042

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

kelvinkipruto
Copy link
Contributor

Description

This PR fixes icon alignment in ClimateMappedAfrica

Fixes #1041

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

image
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@kilemensi
Copy link
Member

kilemensi commented Feb 4, 2025

👍🏽

  1. I think test snapshots may need update,
  2. Can the descriptions also be centred around the icon? "Average Annual Temperature" still looks to a bit to the left of the icon for example.

409500465-0905b283-0d5c-4a77-9971-34bd5bfd2e7c

@kilemensi
Copy link
Member

Is the icon/text alignment issue I mentioned above addressed @kelvinkipruto ?

Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
@kelvinkipruto
Copy link
Contributor Author

@kilemensi It is centred. Looks like the issue is the image itself which has some whitespace around it.
image

@kilemensi
Copy link
Member

@kilemensi It is centred. Looks like the issue is the image itself which has some whitespace around it.

Cool @kelvinkipruto, either lets fix the image or let the data team know that the image has issues.

@kilemensi kilemensi added the bug Something isn't working label Feb 5, 2025
@koechkevin
Copy link
Contributor

Merging this at the authority of @kelvinkipruto

@koechkevin koechkevin added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 2884581 Feb 5, 2025
4 checks passed
@koechkevin koechkevin deleted the fix/fix-data-indicators-alignment branch February 5, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

ClimateMap - Centralize data indicator in the home page
4 participants