Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClimateMappedAfrica: User unable to click the search field #1039

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

koechkevin
Copy link
Contributor

Description

currently, a user is unable to click input to search a location. This is caused by drawer backdrop which prevents actions on other visible elements even after setting a greater zIndex.
This PR changes drawer to persistent and updates styles to maintain how it was.

Fixes #1038

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@koechkevin koechkevin self-assigned this Feb 3, 2025
@koechkevin koechkevin requested a review from a team February 3, 2025 11:31
@koechkevin koechkevin changed the title User unable to click the search field ClimateMappedAfrica: User unable to click the search field Feb 3, 2025
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽


I can't seem to run this app without various errors. If it works on others i.e. if errors are only on my local then all good.
Screenshot 2025-02-04 at 09 09 13

Screenshot 2025-02-04 at 09 13 52

Copy link
Contributor

@kelvinkipruto kelvinkipruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koechkevin koechkevin requested a review from kilemensi February 4, 2025 08:59
@kilemensi
Copy link
Member

If the issues I raised are addressed/commented on @koechkevin, please go ahead with the PR; do not wait for my review.

@koechkevin koechkevin added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 5c3f901 Feb 4, 2025
4 checks passed
@koechkevin koechkevin deleted the bugfix_search_location branch February 4, 2025 13:54
@kilemensi kilemensi mentioned this pull request Feb 24, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClimateMap - Search location issue fix
3 participants