Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

Fixes #212 relating to categories being null from incorrect syntax in posts #214

Merged
merged 4 commits into from
Feb 16, 2015

Conversation

vikingcode
Copy link
Contributor

No description provided.

@laedit
Copy link
Member

laedit commented Feb 15, 2015

Thanks, that was quick!
But i'm not comfortable with the fact to let :categories in the url if there no categories because Pretzel screwed up.
I think Categories should always be at least an empty collection.

@vikingcode
Copy link
Contributor Author

Ah, I hadn't thought of that scenario (I don't use categories on my permalinks). Do you think instead of a null check, if (header.ContainsKey("categories") && header["categories"] is IEnumerable<string>) would be better?

@laedit
Copy link
Member

laedit commented Feb 15, 2015

Yes, that would be great.

@vikingcode
Copy link
Contributor Author

Bam, and the issue is gone (I hope!)

@laedit
Copy link
Member

laedit commented Feb 16, 2015

Excellent, thanks!

laedit pushed a commit that referenced this pull request Feb 16, 2015
Fixes #212 relating to categories being null from incorrect syntax in posts
@laedit laedit merged commit 9e5e5af into Code52:master Feb 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants