Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update page title and add delete functionality #42

Merged
merged 14 commits into from
Apr 12, 2024
Merged

Update page title and add delete functionality #42

merged 14 commits into from
Apr 12, 2024

Conversation

chrisdedman
Copy link
Contributor

@chrisdedman chrisdedman commented Mar 17, 2024 •
edited
Loading

This pull request includes changes to update the page title and add a delete functionality to the pages navigation component.

@chrisdedman chrisdedman self-assigned this Mar 23, 2024
PenguinBoi12
PenguinBoi12 approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@PenguinBoi12 PenguinBoi12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a slight issue with the modal to delete not appearing and some text being able to overlow, all seems good.

I did some adjustment to the layout and fixed the issue mentioned above and the rest looks good.

@PenguinBoi12 PenguinBoi12 merged commit 5abf61c into main Apr 12, 2024
@chrisdedman chrisdedman deleted the update-page-title branch April 12, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PenguinBoi12 PenguinBoi12 PenguinBoi12 approved these changes

Assignees

@chrisdedman chrisdedman

Labels
None yet
Projects
Cursif react client MVP
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisdedman @PenguinBoi12