console: Don't return error for non-existing files #83

cfergeau · 2022-10-21T08:43:28Z

When using NewFileSerialPortAttachment(), the virtualization framework will
create the log file if it does not exist yet.
commit 117c12a added a file existence check to this API, which is incorrect.

Fixes #84

cfergeau · 2022-10-21T09:42:05Z

The failure on the macOS11 builders is not strictly related to this PR

            issues_test.go:112: want underlying error "file does not exist" but got "unsupported macOS version"

cfergeau · 2022-10-21T09:54:44Z

Probably not the best fix, but good enough to get the tests to pass ;)

console.go

Code-Hex · 2022-10-24T12:15:50Z

@cfergeau Create the issue first, as described in the contribution guide.
I will not review anything that does not comply with the rules. (I close your PR)

Ensure the PR description clearly describes the problem and solution. Must be included the relevant issue number.

https://github.com/Code-Hex/vz/blob/master/CONTRIBUTING.md

NewFileSerialPortAttachment was mistakenly used in the 'NewSharedDirectory' test

When using NewFileSerialPortAttachment(), the virtualization framework will create the log file if it does not exist yet. If a directory in the path is invalid, an error will be returned by the virtualization framework, not an exception.This means we don't need to check this in Code-Hex/vz. This commit removes the file existence check which was added in commit 117c12a. This fixes Code-Hex#84

cfergeau · 2022-10-24T12:26:36Z

@cfergeau Create the issue first, as described in the contribution guide. I will not review anything that does not comply with the rules. (I close your PR)

Ensure the PR description clearly describes the problem and solution. Must be included the relevant issue number.

https://github.com/Code-Hex/vz/blob/master/CONTRIBUTING.md

This was missing from some of your recent commits. I assumed this was no longer a strict requirement.

Code-Hex

Thanks

cfergeau force-pushed the console branch 2 times, most recently from 92d0972 to b7b9303 Compare October 21, 2022 09:31

Code-Hex reviewed Oct 24, 2022

View reviewed changes

console.go Outdated Show resolved Hide resolved

cfergeau added 2 commits October 24, 2022 14:24

Fix c&p typo in issues_test.go

672a3cf

NewFileSerialPortAttachment was mistakenly used in the 'NewSharedDirectory' test

cfergeau force-pushed the console branch from 8a83581 to 0842149 Compare October 24, 2022 12:25

Code-Hex approved these changes Oct 24, 2022

View reviewed changes

Code-Hex merged commit d856144 into Code-Hex:master Oct 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

console: Don't return error for non-existing files #83

console: Don't return error for non-existing files #83

cfergeau commented Oct 21, 2022 •

edited by Code-Hex

Loading

cfergeau commented Oct 21, 2022

cfergeau commented Oct 21, 2022

Code-Hex commented Oct 24, 2022 •

edited

Loading

cfergeau commented Oct 24, 2022

Code-Hex left a comment

console: Don't return error for non-existing files #83

console: Don't return error for non-existing files #83

Conversation

cfergeau commented Oct 21, 2022 • edited by Code-Hex Loading

cfergeau commented Oct 21, 2022

cfergeau commented Oct 21, 2022

Code-Hex commented Oct 24, 2022 • edited Loading

cfergeau commented Oct 24, 2022

Code-Hex left a comment

Choose a reason for hiding this comment

cfergeau commented Oct 21, 2022 •

edited by Code-Hex

Loading

Code-Hex commented Oct 24, 2022 •

edited

Loading