Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.6.22 build issue #1161

Closed
ouachman opened this issue Jun 28, 2019 · 6 comments
Closed

Release 1.6.22 build issue #1161

ouachman opened this issue Jun 28, 2019 · 6 comments

Comments

@ouachman
Copy link

Hello,
I just updated my Pod file to use the new version.
Unfortunately when compiling, I get the following error:

"Cannot create __weak reference because the current deployment target does not support weak references"

Hence DTCoreText cannot be built. Is there something missing in the latest release build?

@odrobnik
Copy link
Collaborator

I suspect the __weak instances in the project need to be replaced with DT_WEAK_VARIABLE from DTWeakSupport.h

Can you please find/replace and test if that lets you build? If yes, please send a pull request.

@ouachman
Copy link
Author

Sorry I had to revert to previous version as I had to keep my app stable, so I am unable to do that for the time being :/

@odrobnik
Copy link
Collaborator

@ouachman I made the replacements and retagged the release. it should now work for you if you clear your pod cache and update

@ouachman
Copy link
Author

Thanks for the quick fix. I'll give it a try asap.

@ouachman
Copy link
Author

ouachman commented Jul 1, 2019

Just gave it a try and it works like a charm. Thanks!

@ouachman ouachman closed this as completed Jul 1, 2019
@odrobnik
Copy link
Collaborator

odrobnik commented Jul 1, 2019

@ouachman thank you for confirming that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants