Fixup UUID generation. #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
approved these changes
Nov 29, 2018
5b0ba90 to
ea7ca0d
Compare
|
Adding support for generating UUIDs for multiple projects at once is a nice improvement, worth a |
segiddins
reviewed
Nov 29, 2018
| UUIDGenerator.new([self]).generate! | ||
| end | ||
|
|
||
| def self.predictabilize_uuids(projects) |
| new_objects_by_project = Hash[@projects.map do |project| | ||
| [project, switch_uuids(project)] | ||
| end] | ||
| all_new_objects_by_project = new_objects_by_project.values.map(&:values).flatten |
| end] | ||
| all_new_objects_by_project = new_objects_by_project.values.map(&:values).flatten | ||
| all_objects_by_uuid = @projects.map(&:objects_by_uuid).inject(:merge) | ||
| all_objects = @projects.map(&:objects).flatten |
118ecdc to
b206b2b
Compare
Support the ability to pass in a list of projects that can be used to generate deterministic UUIDs, and also initially pass into UUID generation the project basename such that we have unique UUIDs across all projects.
b206b2b to
9d46a32
Compare
segiddins
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the ability to pass in a list of projects that can be used to generate deterministic UUIDs, and also initially pass into UUID generation the project basename such that we have unique UUIDs across all projects.