Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue CocoaPods/Xcodeproj#409 #410

Merged
merged 1 commit into from
Sep 6, 2016
Merged

Conversation

jeduden
Copy link
Contributor

@jeduden jeduden commented Sep 2, 2016

where can i best put tests for this particular issue ?

@segiddins
Copy link
Member

Probably in the project spec, if you write out a small project file

@jeduden
Copy link
Contributor Author

jeduden commented Sep 3, 2016

@segiddins added a sample project and a test. the underlying issue was that this cases happens only when project that doesn't include the productRefGroup property.

@jeduden
Copy link
Contributor Author

jeduden commented Sep 3, 2016

MMh: "An error occurred while installing activesupport (5.0.0.1), and Bundler cannot" seems unrelated to PR.

@endocrimes
Copy link
Member

@jeduden Sorry about that, this should be fixed by #411

@endocrimes
Copy link
Member

@jeduden This should be good with a rebase

@jeduden
Copy link
Contributor Author

jeduden commented Sep 3, 2016

@dantoml. done.

@jeduden
Copy link
Contributor Author

jeduden commented Sep 4, 2016

@dantoml. the CI build is fixed. thanks!

@orta
Copy link
Member

orta commented Sep 6, 2016

Cool, let's do this then 👍

@orta orta merged commit 0e803d9 into CocoaPods:master Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants