Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.26.0] Version 1.26.0 turns off User sandbox scripting by default and it breaks React Native CI builds #989

Closed
cipolleschi opened this issue Oct 28, 2024 · 6 comments

Comments

@cipolleschi
Copy link

Yesterday (27th of Oct, 2024) The release of xcodeproj 1.26.0 happened.

After the Release, the CI pipelines of React Native and several other projects in the Ecosystem started failing.

We identified the reason to be a change in the value set for the "User Script Sandboxing" settings.

As a patch, we are going to pin the gem version for React Native to < 1.26.0. However, it would be great if we can restore the original behavior.

cipolleschi added a commit to react-native-community/template that referenced this issue Oct 28, 2024
Version 1.26.0 broke the xcodeproj generation by setting the User Sandboxing Script to `true` while previous versions have that set to `false`.

We are avoiding this version of the gem to make sure everything keep working. 

Look at CocoaPods/Xcodeproj#989 for details
@iameli
Copy link

iameli commented Oct 29, 2024

For anyone like me whose CI environment upgraded underneath you and broke your RN builds, this gets the job done:

sudo gem uninstall xcodeproj -x --ignore-dependencies
sudo gem install xcodeproj -v 1.25.1

@amorde
Copy link
Member

amorde commented Oct 29, 2024

Sorry about this. It took me longer than expected to get a CocoaPods release out. 1.16.0 was just released which should address this.

@RubenBez
Copy link

I saw react native also released an update to resolve this

https://github.com/facebook/react-native/releases/tag/v0.76.1

@cipolleschi
Copy link
Author

yeah, for safety, we decided to release with the version pinned. The reason is that we are not forcing everyone to be on the latest cocoapods/xcodeproj version and we don't want to end up in a configuration that is not supported.

@amorde
Copy link
Member

amorde commented Oct 31, 2024

I've released 1.27.0 which reverts the breaking changes to the default build settings, as well as cocoapods 1.16.2 which bumps the min xcodeproj version to 1.27.0

@amorde amorde closed this as completed Oct 31, 2024
@abdulowork
Copy link

On a tangent note: I am not sure it makes sense to enable BUILD_LIBRARY_FOR_DISTRIBUTION. It is unlikely an application wants library evolution to be able enabled in Swift compilations and it might break compilations which otherwise worked fine before (as it did it our case)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants