Merge pull request #383 from somedev/feature-skipped-tests

Skipped tests list support
CocoaPods · Jun 7, 2016 · 1b15f4c · 1b15f4c
2 parents 9188279 + d10e317
commit 1b15f4c
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,7 @@
 * Add accessors for working with skipped tests inside TestAction  in `.xcscheme` files.  
   [Eduard Panasiuk](https://github.com/somedev)
   [#380](https://github.com/CocoaPods/Xcodeproj/pull/380)
+  [#383](https://github.com/CocoaPods/Xcodeproj/pull/383)
 
 ##### Bug Fixes
 

diff --git a/lib/xcodeproj/scheme/test_action.rb b/lib/xcodeproj/scheme/test_action.rb
@@ -152,11 +152,26 @@ def add_buildable_reference(ref)
         #         The list of SkippedTest this action will skip.
         #
         def skipped_tests
+          return [] if @xml_element.elements['SkippedTests'].nil?
           @xml_element.elements['SkippedTests'].get_elements('Test').map do |node|
             TestableReference::SkippedTest.new(node)
           end
         end
 
+        # @param [Array<SkippedTest>] tests
+        #         Set the list of SkippedTest this action will skip.
+        #
+        def skipped_tests=(tests)
+          @xml_element.delete_element('SkippedTests') unless @xml_element.elements['SkippedTests'].nil?
+          if tests.nil?
+            return
+          end
+          entries = @xml_element.add_element('SkippedTests')
+          tests.each do |skipped|
+            entries.add_element(skipped.xml_element)
+          end
+        end
+
         # @param [SkippedTest] skipped_test
         #         The SkippedTest to add to the list of tests this action will skip
         #

diff --git a/spec/scheme/test_action_spec.rb b/spec/scheme/test_action_spec.rb
@@ -203,6 +203,31 @@ module Xcodeproj
         test_ref.xml_element.elements['SkippedTests'].elements['Test'].should == skipped_test.xml_element
       end
 
+      it '#set_skipped_tests_nil' do
+        test_ref = XCScheme::TestAction::TestableReference.new
+        test_ref.skipped_tests = [XCScheme::TestAction::TestableReference::SkippedTest.new]
+        test_ref.skipped_tests.count.should == 1
+        test_ref.skipped_tests = nil
+        test_ref.xml_element.elements['SkippedTests'].should.nil?
+        test_ref.skipped_tests.count.should == 0
+      end
+
+      it '#set_skipped_tests' do
+        test_ref = XCScheme::TestAction::TestableReference.new
+
+        test1 = XCScheme::TestAction::TestableReference::SkippedTest.new
+        test1.identifier = 'MyClassTests1'
+
+        test2 = XCScheme::TestAction::TestableReference::SkippedTest.new
+        test2.identifier = 'MyClassTests2'
+
+        test_ref.skipped_tests = [test1, test2]
+        test_ref.skipped_tests.count.should == 2
+        test_ref.skipped_tests.all? { |e| e.class.should == XCScheme::TestAction::TestableReference::SkippedTest }
+        test_ref.skipped_tests[0].xml_element.should == test1.xml_element
+        test_ref.skipped_tests[1].xml_element.should == test2.xml_element
+      end
+
       it '#skipped_tests' do
         test_ref = XCScheme::TestAction::TestableReference.new