Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RNCryptor/2.0/RNCryptor.podspec #1161

Merged
merged 1 commit into from Jan 29, 2013
Merged

Update RNCryptor/2.0/RNCryptor.podspec #1161

merged 1 commit into from Jan 29, 2013

Conversation

ghost
Copy link

@ghost ghost commented Jan 29, 2013

RNCryptor doesn't use ARC, this fixes it's spec.

RNCryptor doesn't use ARC, this fixes the Podfile.
keith added a commit that referenced this pull request Jan 29, 2013
Update RNCryptor/2.0/RNCryptor.podspec
@keith keith merged commit 7830c1e into CocoaPods:master Jan 29, 2013
@keith
Copy link
Member

keith commented Jan 29, 2013

If you say so 😄

@ghost
Copy link
Author

ghost commented Jan 29, 2013

This is the same mistake that I made in previous repo. Please revert that change, the problem is with dispatch_release method which will make compile error if the target is 6.0 or never.
There should be a way to fix that!

@keith
Copy link
Member

keith commented Jan 29, 2013

Looking into what's going on with this. It may have been changed in 4.6 to disallow dispatch_release in 6.0 with ARC.

@ghost
Copy link
Author

ghost commented Jan 29, 2013

After checking with documentation I've found a fix.

Adding this conditional

#if (TARGET_OS_IPHONE && (__IPHONE_OS_VERSION_MIN_REQUIRED >= __IPHONE_6_0)) || (TARGET_OS_MAC && (MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_8)) 
#undef dispatch_release
#define dispatch_release(object) {}
#undef dispatch_retain
#define dispatch_retain(object) {}
#endif

to the Pods-prefix.pch fixes this problem globally.

The description is available in <os/object.h> file

@ghost
Copy link
Author

ghost commented Jan 29, 2013

New version of this macro, which should work even if someone is building agains older SDKs (as a SDK, not deployment target)

#if (defined __IPHONE_6_0 && TARGET_OS_IPHONE && (__IPHONE_OS_VERSION_MIN_REQUIRED >= __IPHONE_6_0)) || (defined MAC_OS_X_VERSION_10_8 && TARGET_OS_MAC && (MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_8))
#undef dispatch_release
#define dispatch_release(object) {}
#undef dispatch_retain
#define dispatch_retain(object) {}
#endif

@alloy
Copy link
Member

alloy commented Jan 29, 2013

@yappco I have a fix here. I’ll try to merge it and release it tomorrow. If you’re able with Bundler, and would like to try it, that would be much appreciated.

@alloy
Copy link
Member

alloy commented Feb 2, 2013

Just released as version 0.16.2.

keith added a commit that referenced this pull request Jan 29, 2014
Update RNCryptor/2.0/RNCryptor.podspec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants