Skip to content

Commit

Permalink
[Bundle] Update RuboCop
Browse files Browse the repository at this point in the history
  • Loading branch information
segiddins committed Jul 25, 2017
1 parent b5f2ea5 commit 2879add
Show file tree
Hide file tree
Showing 4 changed files with 150 additions and 10 deletions.
4 changes: 3 additions & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
inherit_from: .rubocop_cocoapods.yml
inherit_from:
- .rubocop_cocoapods.yml
- .rubocop_todo.yml

Metrics/LineLength:
Max: 120
Expand Down
11 changes: 10 additions & 1 deletion .rubocop_cocoapods.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ AllCops:
Exclude:
- ./spec/fixtures/**/*
- ./vendor/bundle/**/*
- ./tmp/**/*

# At the moment not ready to be used
# https://github.com/bbatsov/rubocop/issues/947
Expand All @@ -14,6 +15,9 @@ Documentation:

#- CocoaPods -----------------------------------------------------------------#

ParameterLists:
CountKeywordArgs: false

# We adopted raise instead of fail.
SignalException:
EnforcedStyle: only_raise
Expand Down Expand Up @@ -46,7 +50,7 @@ Style/TrailingCommaInArguments:
Style/TrailingCommaInLiteral:
EnforcedStyleForMultiline: comma

Style/MultilineOperationIndentation:
Layout/MultilineOperationIndentation:
EnforcedStyle: indented

# Clashes with CLAide Command#validate!
Expand All @@ -57,6 +61,11 @@ GuardClause:
Next:
Enabled: false

# Autocorrect makes this cop much more useful, taking away needless guessing
Lint/EndAlignment:
AutoCorrect: true


# Arbitrary max lengths for classes simply do not work and enabling this will
# lead to a never ending stream of annoyance and changes.
Metrics/ClassLength:
Expand Down
126 changes: 126 additions & 0 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,126 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2017-07-18 18:42:24 -0500 using RuboCop version 0.49.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 2
# Cop supports --auto-correct.
# Configuration parameters: Include, TreatCommentsAsGroupSeparators.
# Include: **/Gemfile, **/gems.rb
Bundler/OrderedGems:
Exclude:
- 'Gemfile'

# Offense count: 32
# Cop supports --auto-correct.
Layout/EmptyLineAfterMagicComment:
Enabled: false

# Offense count: 1
# Cop supports --auto-correct.
Layout/EmptyLinesAroundExceptionHandlingKeywords:
Exclude:
- 'Rakefile'

# Offense count: 4
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
Layout/IndentHeredoc:
Exclude:
- 'spec/resolver_spec.rb'

# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: symmetrical, new_line, same_line
Layout/MultilineMethodCallBraceLayout:
Exclude:
- 'spec/errors_spec.rb'

# Offense count: 1
Lint/AmbiguousBlockAssociation:
Exclude:
- 'lib/molinillo/modules/ui.rb'

# Offense count: 10
# Configuration parameters: CountComments, ExcludedMethods.
Metrics/BlockLength:
Max: 124

# Offense count: 2
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect.
Security/JSONLoad:
Exclude:
- 'spec/resolver_spec.rb'
- 'spec/spec_helper/index.rb'

# Offense count: 1
# Cop supports --auto-correct.
Style/EmptyLiteral:
Exclude:
- 'spec/spec_helper/specification.rb'

# Offense count: 2
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: compact, expanded
Style/EmptyMethod:
Exclude:
- 'lib/molinillo/dependency_graph/tag.rb'

# Offense count: 2
# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.
# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
Style/FileName:
Exclude:
- 'Gemfile'
- 'Rakefile'

# Offense count: 3
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: when_needed, always, never
Style/FrozenStringLiteralComment:
Exclude:
- 'Gemfile'
- 'Rakefile'
- 'molinillo.gemspec'

# Offense count: 1
# Cop supports --auto-correct.
Style/MultilineIfModifier:
Exclude:
- 'spec/fuzz_spec.rb'

# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
# SupportedStyles: predicate, comparison
Style/NumericPredicate:
Exclude:
- 'spec/**/*'
- 'lib/molinillo/resolution.rb'

# Offense count: 12
# Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters:
Exclude:
- 'molinillo.gemspec'
- 'spec/dependency_graph/log_spec.rb'
- 'spec/dependency_graph_spec.rb'
- 'spec/errors_spec.rb'
- 'spec/fuzz_spec.rb'
- 'spec/state_spec.rb'

# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: MinSize, SupportedStyles.
# SupportedStyles: percent, brackets
Style/SymbolArray:
EnforcedStyle: brackets
19 changes: 11 additions & 8 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ PATH
GEM
remote: https://rubygems.org/
specs:
ast (2.2.0)
ast (2.3.0)
codeclimate-test-reporter (0.4.1)
simplecov (>= 0.7.1, < 1.0.0)
coderay (1.1.1)
Expand All @@ -33,14 +33,16 @@ GEM
method_source (0.8.2)
mime-types (1.25.1)
notify (0.5.2)
parser (2.3.0.6)
parallel (1.11.2)
parser (2.4.0.0)
ast (~> 2.2)
powerpack (0.1.1)
pry (0.10.4)
coderay (~> 1.1.0)
method_source (~> 0.8.1)
slop (~> 3.4)
rainbow (2.1.0)
rainbow (2.2.2)
rake
rake (10.3.2)
rb-fsevent (0.9.4)
rb-inotify (0.9.5)
Expand All @@ -60,13 +62,14 @@ GEM
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.6.0)
rspec-support (3.6.0)
rubocop (0.37.2)
parser (>= 2.3.0.4, < 3.0)
rubocop (0.49.1)
parallel (~> 1.10)
parser (>= 2.3.3.1, < 3.0)
powerpack (~> 0.1)
rainbow (>= 1.99.1, < 3.0)
ruby-progressbar (~> 1.7)
unicode-display_width (~> 0.3)
ruby-progressbar (1.7.5)
unicode-display_width (~> 1.0, >= 1.0.1)
ruby-progressbar (1.8.1)
simplecov (0.14.1)
docile (~> 1.1.0)
json (>= 1.8, < 3)
Expand All @@ -77,7 +80,7 @@ GEM
term-ansicolor (1.3.2)
tins (~> 1.0)
tins (1.8.1)
unicode-display_width (0.3.1)
unicode-display_width (1.3.0)
yard (0.8.7.6)

PLATFORMS
Expand Down

0 comments on commit 2879add

Please sign in to comment.