0.34 rc #160
Merged
0.34 rc #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
|
||
| # @param [Pathname] repos_dir @see repos_dir. | ||
| # @param [<Array<Pathname] repos_dirs @see directories |
There was a problem hiding this comment.
Should this be Array<Pathname>?
There was a problem hiding this comment.
If you are referring to the angled brackets... definitely!
047e7aa to
b69df74
Compare
b69df74 to
9d98426
Compare
|
/cc @alloy @segiddins are we happy with this one? |
| def dependencies_to_lock_pod_named(name) | ||
| result = [] | ||
| deps = dependencies.select { |d| d.root_name == name } | ||
| if deps.empty? | ||
| raise StandardError, "Attempt to lock the `#{name}` Pod without an " \ |
|
Merging for the sake of getting RC1 out. |
kylef
added a commit
that referenced
this pull request
Sep 11, 2014
Ashton-W
pushed a commit
to Ashton-W/Core
that referenced
this pull request
Nov 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #19. The commits of @netbe have been squashed and reworded.