Add tvos as a new platform
#4152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonichu
added a commit
that referenced
this pull request
Sep 10, 2015
| @@ -66,7 +66,7 @@ class UmbrellaTargetDescription | |||
| # | |||
| attr_accessor :specs | |||
|
|
|||
| # @return [Symbol] The platform (either `:ios`, `:watchos` or `:osx`). | |||
| # @return [Symbol] The platform (either `:ios`, `:watchos`, `:tvos` or `:osx`). | |||
|
We probably need to override the code sign settings in the validator as well |
| @@ -189,7 +189,7 @@ def self.add_developers_frameworks_if_needed(xcconfig, platform) | |||
| search_paths = xcconfig.attributes['FRAMEWORK_SEARCH_PATHS'] ||= '' | |||
| search_paths_to_add = [] | |||
| search_paths_to_add << '$(inherited)' | |||
| if platform == :ios || platform == :watchos | |||
| if platform == :ios || platform == :watchos || platform == :tvos | |||
There was a problem hiding this comment.
At some point one of these becomes prettier imo :)
if [:ios, :watchos, :tvos].include?(platform)
# ...
else
# ...
endor
case platform
when :ios, :watchos, :tvos
# ...
else
# ...
end|
Hot hot hot 👍 |
| @@ -84,6 +84,7 @@ def save_as(path) | |||
| def generate_platform_import_header | |||
| case platform.name | |||
| when :ios then "#import <UIKit/UIKit.h>\n" | |||
| when :tvos then "#import <UIKit/UIKit.h>\n" | |||
There was a problem hiding this comment.
I agree, but don't think this PR is the right place to change this stuff. Users will be very confused when UIKit symbols are suddenly undefined for just one of the UIKit platforms.
|
👍 but this needs a rebase |
|
I've rebased this, will merge once the dependent PRs have all been merged |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.