Unset the CDPATH env variable before shelling-out. #1694
#1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@apalancat it would be great for this to have a test, yes! |
|
Also a small note in the documentation of the method referencing the original issue would be helpful... finally don't forget to add an entry to changelog and credit yourself! |
|
Not sure if I messed up by doing a merge of 0.30 and updating the PR, let me know if I should change anything. |
|
Issue has been confirmed by @AhmadAlokush |
|
Thanks 🍷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess bash is only used in
run_prepare_command, but I'm not sure if theCDPATHshould be unset globally at some other point so it can't create problems in the future.Also, should this have a test?