Skip to content
This repository has been archived by the owner on Nov 3, 2020. It is now read-only.

Pod Deintegrate #296

Merged
merged 5 commits into from
Apr 26, 2016
Merged

Pod Deintegrate #296

merged 5 commits into from
Apr 26, 2016

Conversation

nwest
Copy link
Member

@nwest nwest commented Apr 22, 2016

Closes #283.

Using the app, this enables removing CocoaPods integration from a project.

screen shot 2016-04-22 at 3 39 01 pm

screen shot 2016-04-22 at 3 39 13 pm

@CocoaPodsBarista
Copy link

      <tr>
    <td>:white_check_mark:</td>
    <td data-sticky="true"><del><p>Please include a CHANGELOG entry to credit yourself! 

You can find it at CHANGELOG.md.


        :white_check_mark: Nice work.
    
  </th>
 </tr>

Generated by 🚫 danger

@nwest nwest force-pushed the pod-deintegrate branch from 49cf3dd to 032fcc5 Compare April 22, 2016 19:38
@@ -134,6 +134,13 @@
</items>
</menu>
</menuItem>
<menuItem isSeparatorItem="YES" id="wV5-hB-goc"/>
<menuItem title="Remove CocoaPods From A Project..." id="fXB-fZ-GrP">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make this: "Remove CocoaPods From a Project…" ( lowercase a, and single char …)

@orta
Copy link
Member

orta commented Apr 22, 2016

minor wording, looks good

self.completionHandler(nil)
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing newline

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ Could be a Danger rule 👯

@nwest nwest force-pushed the pod-deintegrate branch from c2f27d8 to 8b979e9 Compare April 23, 2016 13:44
@orta
Copy link
Member

orta commented Apr 23, 2016

Alright, if this greens - we're good to go

@orta orta merged commit 2698165 into master Apr 26, 2016
@orta orta deleted the pod-deintegrate branch April 26, 2016 12:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants