This repository has been archived by the owner on Nov 3, 2020. It is now read-only.
Add the Git Credential Helper to the destroot - fixes #259 #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright, this fixes that: Tada: |
|
@alloy - any chance you can do a quick look at this ~20 LOC change the Rakefile, I'm confident in it, but maybe there's a better way I missed. |
|
Looks like I missed the bit where it actually downloaded the file - hah |
| define_download_task | ||
| download_task | ||
| install_task | ||
| end |
There was a problem hiding this comment.
This actually performs the download and installation tasks, whereas it should only define tasks that can do that.
417b0e8 to
9618a2c
Compare
…ods-app into keychain_thingy
|
OK, this is now running fine 👍🏾 - same fail as #281 |
| end | ||
|
|
||
| def install_task | ||
| execute 'cp', File.join(DOWNLOAD_DIR, artefact_file), File.join(BUNDLE_PREFIX, installed_file) |
There was a problem hiding this comment.
Why the execute? Can just use cp, it's mixed in from FileUtils
|
📗 LGTM |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My internet is too slow to verify this yet, so no merging until this is confirmed ( CI will run through the process - so I'm kinda interested in what happens there )