Support highlighting CP DSL errors when they are not ruby syntax issues

[orta]

@alloy @segiddins - incase I'm missing some additional context the I don't know about WRT DSL errors from CP.

Fixes #204

[orta]

[orta]

I've been running with this all day and testing on different podfiles, not seen any adverse effects.

[alloy]

The way the message and line info is parsed seems like it's more complex to me than should be needed. An informative error should at least have a proper backtrace, no? It should als hold an unprettified message imp.

[alloy]

s/imp/imo/

[orta]

No, in this case the backtrace is entirely within CocoaPods's source files alas - see the one in #204

[alloy]

I see Podfile:14 in the second frame of that backtrace, which is where I mean to get the info from.

What I really mean is that there should not be a reason to parse this information from a exception’s message. That’s too brittle imo, as the formatting of that message might easily change. So either get the info from its canonical location (file:line from backtrace) or change the way the info is stored in CP (i.e. have the exception hold the unformatted message as well: Unsupported options '{:exclusive=>true}' for target 'Aerodramus_Example'.) @segiddins might know if this is not already possible.

The only reason the parsing is done in the case of a SyntaxError is because it’s a special kind of exception related to Ruby, namely one during parsing and thus the file never did load.

[orta]

Yeah, this all makes sense, will see what @segiddins says about getting the structured message, but made myself an issue

[alloy]

👍

[segiddins]

Iirc there's a parse line and offset method on DSLError already?