Pod name completion while editing Podfile #197
Conversation
| @@ -44,6 +54,13 @@ class CPPodfileEditorViewController: NSViewController, NSTextViewDelegate { | |||
| syntaxChecker.textDidChange(NSNotification(name: "", object: nil)) | |||
| } | |||
|
|
|||
| func completions() -> [AnyObject]! { | |||
There was a problem hiding this comment.
Unfortunately, this is how it's declared in SMLAutoCompleteDelegate. If I change the return type in the implementation, the build errors for non protocol conformance.
There was a problem hiding this comment.
how often is this called? Is it left to Fragaria to deal with scoping?
|
Ah yeah! |
I think you need to pull them out of here: https://github.com/CocoaPods/CocoaPods-app/blob/master/app/CocoaPods/Supporting%20Files/Syntax%20Definitions/Podfile.plist and add them to the array you're showing. |
|
Great, so this will will need a rebase and it's good to go 👍 |
|
@nwest please rebase instead of merging master to keep history clean? |
Pod name completion while editing Podfile
|
🎉 |
|
@segiddins ah, I'll know to rebase in the future. |
Implements #19. Autocomplete can be toggled with ESC.
This likely broke autocompletion of the Podfile methods (https://github.com/nwest/CocoaPods-app/commit/50f69427ee90c9d319fb3b6aaecce8b32e5b7821use_frameworks!for e.g). I'll find a way to pull those in to this delegation pattern.