Fix #36: No --verbose --help backtrace #37
Conversation
Required for the examples
So we need to pay less attention to implementation details in the specs for mocking the right methods
| end | ||
| error.should.not.nil? | ||
| end | ||
|
|
There was a problem hiding this comment.
Does this not work with the following?
should.raise SystemExit do
raise SystemExit
endThere was a problem hiding this comment.
Right. This could be stated simpler. In the helper method or directly in the specs?
|
Besides that question this all looks good to me. Great work! Once I have your answer I will merge this. |
| @@ -4,6 +4,7 @@ gem 'rake' | |||
|
|
|||
| group :development do | |||
| gem 'kicker' | |||
| gem 'colored' # for examples | |||
There was a problem hiding this comment.
Because examples/make.rb has a static require 'colored'.
There was a problem hiding this comment.
I think that it can just be removed from the examples. Now Xcodeproj vendors its on ANSI stuff
There was a problem hiding this comment.
But this is a separate issue, isn't it?
There was a problem hiding this comment.
It would have been but this was included in the path. Anyway I agree lets leave it for another issue.
Fix #36: No --verbose --help backtrace
|
Ace work! 👍 |
Fixes #36.