Skip to content

Commit

Permalink
fix: Do not output warning logs when job is not present in job queue
Browse files Browse the repository at this point in the history
AB#44195
  • Loading branch information
hopengfoong committed Jan 23, 2025
1 parent 4f89e87 commit 4fc5c12
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions src/Connector.DataLake.Common/DataLakeScheduler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,15 @@ async Task addStreamExportJobs(ExecutionContext executionContext, ProviderDefini
if (stream.Mode != StreamMode.Sync)
{
_logger.LogDebug("Stream {StreamId} is not in {Mode} mode. Removing it from scheduler '{SchedulerName}'.", stream.Id, StreamMode.Sync, _schedulerName);
removeExportJob(jobKey);
removeExportJob(jobKey, warnIfNotRemoved: false);
return;
}

var jobSchedule = await _dataLakeJobDataFactory.GetScheduleAsync(executionContext, stream);
if (IsExportJobDisabled(jobSchedule))
{
_logger.LogDebug("Stream {StreamId} is disabled. Removing it from scheduler '{SchedulerName}'.", stream.Id, _schedulerName);
removeExportJob(jobKey);
_logger.LogDebug("Stream {StreamId} export is disabled. Removing it from scheduler '{SchedulerName}'.", stream.Id, _schedulerName);
removeExportJob(jobKey, warnIfNotRemoved: false);
return;
}

Expand All @@ -72,7 +72,7 @@ async Task addStreamExportJobs(ExecutionContext executionContext, ProviderDefini
var removed = 0;
foreach (var jobKey in jobKeysToRemove)
{
removeExportJob(jobKey);
removeExportJob(jobKey, warnIfNotRemoved: true);
removed++;
}

Expand All @@ -81,15 +81,15 @@ async Task addStreamExportJobs(ExecutionContext executionContext, ProviderDefini
_logger.LogInformation("Total of obsolete {RemovedCount} stream jobs removed from scheduler '{SchedulerName}'.", removed, _schedulerName);
}

void removeExportJob(string jobKey)
void removeExportJob(string jobKey, bool warnIfNotRemoved)
{
if (jobQueue.TryRemove(jobKey, out var _))
{
_logger.LogDebug("Stream export for stream {StreamId} removed from scheduler '{SchedulerName}'.", jobKey, _schedulerName);
}
else
else if (warnIfNotRemoved)
{
_logger.LogWarning("Failed to disable stream export for stream {StreamId} from scheduler '{SchedulerName}'..", jobKey, _schedulerName);
_logger.LogWarning("Failed to disable stream export for stream {StreamId} from scheduler '{SchedulerName}'.", jobKey, _schedulerName);
}
}
}
Expand Down

0 comments on commit 4fc5c12

Please sign in to comment.