🐛 Simplify download_with_progress inputs and fix clean up logic #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kevinsantana11
commented
Aug 7, 2024
- File buffers were not being closed correctly when exceptions were raised
- Move buffer management logic to top level function
- Passed in buffers are no longer closed when an exception is raised.
- Pull expected size from Content-Length header
* File buffers were not being closed correctly when exceptions were raised * Move buffer management logic to top level function * Passed in buffers are no longer closed when an exception is raised. * Pull expected size from Content-Length header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.