🧹 Update type comparison in ragged.py #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code changes in ragged.py update the type comparison for the `tolerance` variable. Instead of using the `type()` function, it now uses the `isinstance()` function to check if `tolerance` is an instance of `pd.Timedelta`. This change improves the accuracy and reliability of the comparison. Note: This commit message follows the established convention of using the "chore" type for non-functional changes that don't affect the code's behavior.
|
Fyi Refactoring is at two spots. |
|
@philippemiron thanks for the heads up |
kevinsantana11
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code changes in ragged.py update the type comparison for the
tolerancevariable. Instead of using thetype()function, it now uses theisinstance()function to check iftoleranceis an instance ofpd.Timedelta. This change improves the accuracy and reliability of the comparison.Note: This commit message follows the established convention of using the "chore" type for non-functional changes that don't affect the code's behavior.