Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔎 type comparison with isinstance #491

Merged
merged 1 commit into from
Jul 16, 2024
Merged

🔎 type comparison with isinstance #491

merged 1 commit into from
Jul 16, 2024

Conversation

philippemiron
Copy link
Contributor

@philippemiron philippemiron commented Jul 15, 2024 •
edited
Loading

Small refactoring to use isinstance() instead of type() is.

kevinsantana11
kevinsantana11 approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@kevinsantana11 kevinsantana11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@philippemiron philippemiron merged commit 079ae36 into Cloud-Drift:main Jul 16, 2024
13 of 14 checks passed
@philippemiron philippemiron deleted the isinstance branch July 16, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinsantana11 kevinsantana11 kevinsantana11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippemiron @kevinsantana11