chore: Convert xarray variables to numpy arrays for consistent operat… #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions in kinematics.velocity_from_position and kinematics.position_from_velocity
|
I don't know if someone has time, but keeping the DataArray would be better than just converting to numpy array. |
|
In which ways @philippemiron ? Other functions in this module typically return numpy arrays when the inputs are dataarrays. |
|
Oh ok. I thought most of them were preserving types. I guess it's fine then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ions in kinematics.velocity_from_position and kinematics.position_from_velocity
fix #440