-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 python 3.10 upgrade #391
🔧 python 3.10 upgrade #391
Conversation
Looks good! I found one more thing to modify here: https://github.com/Cloud-Drift/clouddrift/blob/main/.github/workflows/ci.yml#L22 |
@philippemiron I see there's another PR with changes involving micro-mamba running our tests on 3.12 instead of 3.9. I pulled in one of the commits from that branch so that those changes can all be committed together unless you think its better to commit these separately |
I think in general we should not merge commits from others PR.
I don't really care since I've collaborated to the project already, but that could different for a new collaborator for example. |
That's fair, should I remove the previous commit? Unsure if maybe we need to merge the #392 first and then this PR. If so I can create a commit reverting it. |
I think if we merge the other one first, we won't have to do anything here. |
upgrade to python 3.10. Many of the typing changes arose from using the
pyupgrade --py310-plus
upgrade command. fixes #335