Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 python 3.10 upgrade #391

Merged
merged 6 commits into from
Apr 11, 2024

Conversation

kevinsantana11
Copy link
Contributor

upgrade to python 3.10. Many of the typing changes arose from using the pyupgrade --py310-plus upgrade command. fixes #335

@kevinsantana11 kevinsantana11 changed the title Python 3 10 upgrade 🔧 python 3.10 upgrade Apr 10, 2024
@philippemiron
Copy link
Contributor

Looks good!

I found one more thing to modify here:

https://github.com/Cloud-Drift/clouddrift/blob/main/.github/workflows/ci.yml#L22

@selipot selipot added the enhancement New feature or request label Apr 10, 2024
@kevinsantana11
Copy link
Contributor Author

@philippemiron I see there's another PR with changes involving micro-mamba running our tests on 3.12 instead of 3.9. I pulled in one of the commits from that branch so that those changes can all be committed together unless you think its better to commit these separately

@philippemiron
Copy link
Contributor

philippemiron commented Apr 11, 2024

I think in general we should not merge commits from others PR.

  • lose attributions for the history
  • lose attributions for the release
  • lose track of what has been changed since we do squash and merge

I don't really care since I've collaborated to the project already, but that could different for a new collaborator for example.

@kevinsantana11
Copy link
Contributor Author

I think in general we should not merge commits from others PR.

* lose attributions for the history

* lose attributions for the release

* lose track of what has been changed since we do squash and merge

I don't really care since I've collaborated to the project already, but that could different for a new collaborator for example.

That's fair, should I remove the previous commit? Unsure if maybe we need to merge the #392 first and then this PR. If so I can create a commit reverting it.

@philippemiron
Copy link
Contributor

I think if we merge the other one first, we won't have to do anything here.

@kevinsantana11 kevinsantana11 merged commit c488f0d into Cloud-Drift:main Apr 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

python 3.10 upgrade
3 participants