Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Integrate doctest to run on our ragged.py module #381

Merged
merged 13 commits into from
Apr 11, 2024

Conversation

kevinsantana11
Copy link
Contributor

Tool Documentation: https://docs.python.org/3/library/doctest.html#

Currently the integration only runs on our ragged.py module. This is related to #380

@kevinsantana11 kevinsantana11 changed the title Integrate doctest to run on our ragged.py module 🔧 Integrate doctest to run on our ragged.py module Mar 23, 2024
@selipot
Copy link
Member

selipot commented Apr 9, 2024

@kevinsantana11 does this tool automatically correct the docstrings or do we do it manually? And what is the strategy? To do a PR for each module?

@kevinsantana11
Copy link
Contributor Author

@kevinsantana11 does this tool automatically correct the docstrings or do we do it manually? And what is the strategy? To do a PR for each module?

This won't automatically correct our docstrings for us. What it will do is run the code it finds in our docstrings and detect if the code is invalid (wrong syntax, missing imports, throws an exception, etc...) or provides the wrong output (the expected output follows the code defined by the 3 angle brackets >>>). Similarly to unit tests if the doctests fail we need to go in and manually fix the code.

As far as strategy maybe we should create a project where we have one issue per module. I can then pickup a doctest issues roughly bi-weekly

I want to do this for mypy typing as well as that also need a migration strategy that's done over time.

@kevinsantana11 kevinsantana11 marked this pull request as ready for review April 10, 2024 02:50
@selipot selipot added the enhancement New feature or request label Apr 10, 2024
@kevinsantana11
Copy link
Contributor Author

starts #398

@kevinsantana11 kevinsantana11 merged commit a6e42c1 into Cloud-Drift:main Apr 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants