-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 Integrate doctest to run on our ragged.py
module
#381
🔧 Integrate doctest to run on our ragged.py
module
#381
Conversation
e362634
to
06871a9
Compare
ragged.py
moduleragged.py
module
3de6b1f
to
42fa585
Compare
@kevinsantana11 does this tool automatically correct the docstrings or do we do it manually? And what is the strategy? To do a PR for each module? |
This won't automatically correct our docstrings for us. What it will do is run the code it finds in our docstrings and detect if the code is invalid (wrong syntax, missing imports, throws an exception, etc...) or provides the wrong output (the expected output follows the code defined by the 3 angle brackets >>>). Similarly to unit tests if the doctests fail we need to go in and manually fix the code. As far as strategy maybe we should create a project where we have one issue per module. I can then pickup a doctest issues roughly bi-weekly I want to do this for mypy typing as well as that also need a migration strategy that's done over time. |
aa3da3f
to
89c339e
Compare
starts #398 |
Tool Documentation: https://docs.python.org/3/library/doctest.html#
Currently the integration only runs on our ragged.py module. This is related to #380