Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subset docstring edit #364

Merged
merged 2 commits into from
Jan 27, 2024
Merged

subset docstring edit #364

merged 2 commits into from
Jan 27, 2024

Conversation

selipot
Copy link
Member

@selipot selipot commented Jan 26, 2024

I think it is necessary to clarify in the docstring that the id_var_name variable is expected to have the dimension "traj" or traj_dim_name. We have changed several times the conventions for the dimensions of the id and traj variables.

@selipot selipot self-assigned this Jan 26, 2024
@selipot selipot added the enhancement New feature or request label Jan 26, 2024
@selipot selipot requested a review from philippemiron January 26, 2024 22:20
@selipot
Copy link
Member Author

selipot commented Jan 26, 2024

This turns out necessary for me because I was reading a local version of the version 2.01 not doing what the datasets.gdp1h() function does:

url = "https://noaa-oar-hourly-gdp-pds.s3.amazonaws.com/latest/gdp-v2.01.zarr"
ds = xr.open_dataset(url, engine="zarr", decode_times=decode_times)
ds = ds.rename_vars({"ID": "id"}).assign_coords({"id": ds.ID}).drop_vars(["ids"])

@selipot selipot merged commit 2dd835c into Cloud-Drift:main Jan 27, 2024
1 of 13 checks passed
@selipot selipot deleted the subset-doc-fix branch January 27, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants