Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yomaha and andro datasets #322

Merged
merged 17 commits into from
Dec 14, 2023
Merged

yomaha and andro datasets #322

merged 17 commits into from
Dec 14, 2023

Conversation

philippemiron
Copy link
Contributor

@philippemiron philippemiron commented Nov 14, 2023

Resolves #319

  • working implementation
  • look at ANDRO and see if this could be combined here or should just be another datasets
  • YoMaHa: include WMO id, DAC, and argo type (3 "traj" variables)
  • clean up code
  • add docstring and references
  • rename variables
  • add attributes
  • wrap in clouddrift.datasets
  • add tests

@philippemiron
Copy link
Contributor Author

philippemiron commented Nov 15, 2023

Not sure what the strategy could be to test those datasets since it involved downloading a ~300-400Mb ASCII file.

@philippemiron philippemiron added the arhicved-label-data-adapters Adapters for custom datasets into CloudDrift label Nov 16, 2023
@milancurcic
Copy link
Member

We test for GLAD which involves a ~150MB download and it takes a few seconds in CI. So it may be OK to try doing the same here and see how it goes. I don't know for certain but I expect that frequent file downloads in CI are cached in their local CDN.

@philippemiron philippemiron requested review from selipot and milancurcic and removed request for selipot December 8, 2023 15:51
@philippemiron philippemiron changed the title yomaha dataset yomaha and andro datasets Dec 8, 2023
Copy link
Member

@selipot selipot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! We need example notebooks!

@selipot selipot merged commit cc074b0 into Cloud-Drift:main Dec 14, 2023
15 checks passed
@philippemiron philippemiron deleted the argo_traj branch December 16, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arhicved-label-data-adapters Adapters for custom datasets into CloudDrift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ANDRO: An Argo-based deep displacement dataset adapter
3 participants