Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLAD adapter and dataset accessor #318

Merged
merged 10 commits into from
Nov 13, 2023
Merged

GLAD adapter and dataset accessor #318

merged 10 commits into from
Nov 13, 2023

Conversation

milancurcic
Copy link
Member

@milancurcic milancurcic commented Nov 9, 2023 •
edited
Loading

Closes #61.

  • Adapter
    • Implementation
    • Docs
  • Dataset
    • Implementation
    • Docs
    • Test

@milancurcic milancurcic added enhancement New feature or request arhicved-label-data-adapters Adapters for custom datasets into CloudDrift labels Nov 9, 2023
@milancurcic milancurcic self-assigned this Nov 9, 2023
philippemiron
philippemiron reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor

@philippemiron philippemiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@milancurcic
Copy link
Member Author

Thanks for reviewing; will merge.

@milancurcic milancurcic merged commit a27e421 into Cloud-Drift:main Nov 13, 2023
12 checks passed
@milancurcic milancurcic deleted the glad branch November 13, 2023 18:17
philippemiron pushed a commit to philippemiron/clouddrift that referenced this pull request Nov 16, 2023
@milancurcic @selipot
GLAD adapter and dataset accessor (Cloud-Drift#318)
29b354e 
* Initial implementation of GLAD adapter

* Bump version

* Variable attributes

* Global attributes

* Add datasets.glad

* Test that GLAD opens

* Add GLAD to Sphinx docs

* Update __init__.py

* Update __init__.py

---------

Co-authored-by: Shane Elipot <selipot@miami.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippemiron philippemiron philippemiron left review comments

@selipot selipot selipot approved these changes

Assignees

@milancurcic milancurcic

Labels
arhicved-label-data-adapters Adapters for custom datasets into CloudDrift enhancement New feature or request
Projects
Data adapters
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GLAD dataset adapter
3 participants
@milancurcic @philippemiron @selipot