Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inertial modifications #310

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Inertial modifications #310

merged 4 commits into from
Oct 30, 2023

Conversation

selipot
Copy link
Member

@selipot selipot commented Oct 26, 2023

This PR does three things

  1. slightly change the names of the functions to remove plural forms to be consistent
  2. fix output types not consistent for residual_positions_from_displacements #309
  3. implement a new feature of inertial_oscillation_from_position whereas the user can input the wavelet duration instead of the bandwidth.

@selipot selipot added the enhancement New feature or request label Oct 26, 2023
@selipot selipot self-assigned this Oct 26, 2023
@milancurcic milancurcic marked this pull request as ready for review October 30, 2023 14:55
milancurcic
milancurcic approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes, thank you.

@milancurcic milancurcic merged commit 06a492b into Cloud-Drift:main Oct 30, 2023
philippemiron pushed a commit to philippemiron/clouddrift that referenced this pull request Nov 16, 2023
@selipot
Inertial modifications (Cloud-Drift#310)
683c776 
* name changes

* xarray conversion

* add optional argument

* expanded example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milancurcic milancurcic milancurcic approved these changes

@philippemiron philippemiron philippemiron approved these changes

Assignees

@selipot selipot

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

output types not consistent for residual_positions_from_displacements
3 participants
@selipot @philippemiron @milancurcic