-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diagrams_in_doc #257
Diagrams_in_doc #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philippemiron How can I see the rendering of these changes?
You need to build the docs locally, the instructions are also here.
Then you can open |
Thanks @philippemiron I feel you told me that before |
No worries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, great addition.
It has not occurred to me that, as @selipot just pointed out on our call, that having the RST code to insert an image in the Python docstring itself is unfriendly to users reading the docstring from the Python prompt. This is probably why Philippe attempted to place them in api.rst, though that didn't render the images for me. Let's find a way to include graphics in the function docs without polluting the docstring itself, perhaps by looking at how other projects do this (maybe Xarray? not sure). |
and I agree (I missed the previous commits) that we don't want to have this in the docstrings of the functions itself. |
I either initially did something wrong or I didn't scroll down enough to see them because they appear at the bottom of the |
* add diagram to doc * remove warnings * Move Sphinx code for chunk illustrations into the code docstrings * Add a hook for the ragged-array illustration * Revert to chunk diagrams via api.rst --------- Co-authored-by: Philippe Miron <philippe.miron@dtn.com> Co-authored-by: milancurcic <caomaco@gmail.com>
I will let you add some text and/or move those around. But here is a good start for #251.