Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nallo tags to mimic raredisease for scout upload #134

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rannick
Copy link
Contributor

@rannick rannick commented Feb 14, 2025

Description

Added

Changed

Fixed

Testing

How to prepare for test

  • ssh to Hasta
  • Test your branch with
hermes-test-deploy <branch-name>
hermes-test <command here>

How to test

  • login to ...
  • do ...

Expected test result

  • check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • code approved by
  • tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@rannick rannick self-assigned this Feb 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.80%. Comparing base (0bd12a2) to head (72e0071).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   92.80%   92.80%           
=======================================
  Files          29       29           
  Lines        1015     1015           
=======================================
  Hits          942      942           
  Misses         73       73           
Flag Coverage Δ
unittests 92.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants