Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat, prio order for balsamic #637

Closed
wants to merge 3 commits into from
Closed

Conversation

hassanfa
Copy link
Contributor

@hassanfa hassanfa commented May 7, 2020

This PR suggests a reformed priority order for BALSAMIC runs:

The oder is:

  1. Check if priority is provided by user
  2. Check if case_obj has job priority
  3. take from BALSAMIC qos value in cg.yaml

Also a bit of code formatting and linting.

How to prepare for test:

  • ssh to hasta (depending on type of change)
  • install on stage:
    bash servers/resources/hasta.scilifelab.se/update-cg-stage.sh [THIS-BRANCH-NAME]
  • ssh to clinical-db (depending on type of change)
  • install on stage:
    bash servers/resources/clinical-db.scilifelab.se/update-clinical-api-stage.sh [THIS-BRANCH-NAME]

How to test:

  • login to ...
  • do ...

Expected test outcome:

  • check that ...
  • Take a screenshot and attach or copy/paste the output.

Review:

  • code approved by
  • tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@coveralls
Copy link
Collaborator

Coverage Status

Coverage increased (+0.008%) to 63.957% when pulling 2128f6f on balsamic_get_prio_statusdb into d225119 on master.

@barrystokman
Copy link
Contributor

Can you add the information about the test cases/expected outcome and so on?

@barrystokman
Copy link
Contributor

Something to discuss in general: it took me a while to find the actual code change. In the future, can we put the blacking in separate commits?

@hassanfa
Copy link
Contributor Author

hassanfa commented May 8, 2020

Can you add the information about the test cases/expected outcome and so on?

I'm on it. Hasta was down and I couldn't test it yet. Thus couldn't propose a good test scenario.

Something to discuss in general: it took me a while to find the actual code change. In the future, can we put the blacking in separate commits?

Good point. I actually thought I did commit black and code change but I made a mistake there... if it is hard to review without distinct code change, I can try to fix it: revert changes and commit code again from scratch or open a new PR.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@barrystokman
Copy link
Contributor

I can try to fix it: revert changes and commit code again from scratch or open a new PR.

No it's fine, but it's something for all of us to consider for future commits.

@hassanfa hassanfa marked this pull request as draft May 10, 2020 16:51
@Mropat
Copy link
Contributor

Mropat commented Aug 17, 2020

This feature is also added in #687

@hassanfa hassanfa closed this Aug 17, 2020
@hassanfa hassanfa deleted the balsamic_get_prio_statusdb branch August 17, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants