-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat, prio order for balsamic #637
Conversation
Can you add the information about the test cases/expected outcome and so on? |
Something to discuss in general: it took me a while to find the actual code change. In the future, can we put the blacking in separate commits? |
I'm on it. Hasta was down and I couldn't test it yet. Thus couldn't propose a good test scenario.
Good point. I actually thought I did commit |
Kudos, SonarCloud Quality Gate passed!
|
No it's fine, but it's something for all of us to consider for future commits. |
This feature is also added in #687 |
This PR suggests a reformed priority order for BALSAMIC runs:
The oder is:
qos
value incg.yaml
Also a bit of code formatting and linting.
How to prepare for test:
bash servers/resources/hasta.scilifelab.se/update-cg-stage.sh [THIS-BRANCH-NAME]
bash servers/resources/clinical-db.scilifelab.se/update-clinical-api-stage.sh [THIS-BRANCH-NAME]
How to test:
Expected test outcome:
Review:
Thanks for filling in who performed the code review and the test!
This version is a: