Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store balsamic #551

Merged
merged 76 commits into from
Mar 25, 2020
Merged

Store balsamic #551

merged 76 commits into from
Mar 25, 2020

Conversation

patrikgrenfeldt
Copy link
Contributor

@patrikgrenfeldt patrikgrenfeldt commented Feb 12, 2020

This PR adds cg capability to store balsamic case files in housekeeper

TODO:

  • call balsamic to create meta file
  • parse meta file to add tags to each file
  • parse meta file to collect folders
  • run folders to add all files
  • run folders to add all files

How to prepare for test:

  • install on stage of the hasta machine: bash servers/resources/hasta.scilifelab.se/update-cg-stage.sh store-balsamic
  • activate stage: us

How to test basic storing:

  • run following command: cg workflow balsamic store analysis [CASEID]

Expected test outcome:

  • files stored successfully in housekeeper

How to test storing using a deliverables-file:

  • run following command: cg workflow balsamic store analysis --deliverables-file [CASE-METAFILE] [CASEID]

Expected test outcome:

  • files stored successfully in housekeeper

How to test creating an deliverables-file:

  • run following command: cg workflow balsamic store generate-deliverables-file [CASEID]

Expected test outcome:

  • deliverables file generated
  • Take a screenshot and attach or copy/paste the output.

Review:

This is |minor| version bump because it adds functionality in a backwards compatible way

@patrikgrenfeldt
Copy link
Contributor Author

@hassanfa could I get your opinion on the storing of balsamic files in housekeeper?

@hassanfa
Copy link
Contributor

@hassanfa could I get your opinion on the storing of balsamic files in housekeeper?

Awesome! I'll try my best. Can I do that on Friday please?

@patrikgrenfeldt
Copy link
Contributor Author

Awesome! I'll try my best. Can I do that on Friday please?

Sure!

@patrikgrenfeldt
Copy link
Contributor Author

I also asked @sylvinite for a code review to get some reviewing back and forth. I'm still curious about your thoughts on the Balsamic specifics @hassanfa 😄

@barrystokman
Copy link
Contributor

How to test:

run following command: cg workflow balsamic store analysis [CASE-METAFILE] [CASEID]

@patrikgrenfeldt @hassanfa Do you have a [CASE-METAFILE] and [CASEID] I can use to test on stage?

@hassanfa
Copy link
Contributor

Scanning through this, are you sure it is following the discussions in #475

I see the dummy file in tests is still the old format

@hassanfa
Copy link
Contributor

@barrystokman I don't have any test cases for this, it is not on Balsamic 4.1.0 yet. Plan is for end of next week to make a release.

@patrikgrenfeldt patrikgrenfeldt changed the title WIP - Store balsamic Store balsamic Mar 25, 2020
Copy link
Contributor

@adrosenbaum adrosenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but I have some comments.

@patrikgrenfeldt
Copy link
Contributor Author

test result linked files:
image
👍

@patrikgrenfeldt
Copy link
Contributor Author

Test result housekeeper:
image
👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 1 Security Hotspot to review)
Code Smell A 21 Code Smells

No Coverage information No Coverage information
1.9% 1.9% Duplication

@patrikgrenfeldt patrikgrenfeldt merged commit 59755ac into master Mar 25, 2020
@patrikgrenfeldt patrikgrenfeldt deleted the store-balsamic branch March 25, 2020 15:58
@patrikgrenfeldt
Copy link
Contributor Author

deployed on hasta and clinical-db

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants