-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store balsamic #551
Store balsamic #551
Conversation
@hassanfa could I get your opinion on the storing of balsamic files in housekeeper? |
Awesome! I'll try my best. Can I do that on Friday please? |
Sure! |
I also asked @sylvinite for a code review to get some reviewing back and forth. I'm still curious about your thoughts on the Balsamic specifics @hassanfa 😄 |
@patrikgrenfeldt @hassanfa Do you have a |
Scanning through this, are you sure it is following the discussions in #475 I see the dummy file in tests is still the old format |
@barrystokman I don't have any test cases for this, it is not on Balsamic 4.1.0 yet. Plan is for end of next week to make a release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but I have some comments.
Kudos, SonarCloud Quality Gate passed!
|
deployed on hasta and clinical-db |
This PR adds cg capability to store balsamic case files in housekeeper
TODO:
How to prepare for test:
bash servers/resources/hasta.scilifelab.se/update-cg-stage.sh store-balsamic
us
How to test basic storing:
cg workflow balsamic store analysis [CASEID]
Expected test outcome:
How to test storing using a deliverables-file:
cg workflow balsamic store analysis --deliverables-file [CASE-METAFILE] [CASEID]
Expected test outcome:
How to test creating an deliverables-file:
cg workflow balsamic store generate-deliverables-file [CASEID]
Expected test outcome:
Review:
Thanks for filling in who performed the code review and the test!
This is |minor| version bump because it adds functionality in a backwards compatible way