Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate link for exact match for sample and case #4202

Merged

Conversation

beatrizsavinhas
Copy link
Contributor

@beatrizsavinhas beatrizsavinhas commented Feb 12, 2025

Description

Closes #3998.

Changed

  • The link generated by clicking a sample or case entry in statusDB web to provide an exact match.

How to prepare for test

  • Local deployment of cg

How to test

  • Search for sample STG15809A2 and click the sample link.
  • Search for case adjustedkit and click the case link.
  • Repeat these tests from the Case Sample table.

Expected test outcome

  • Check that the results from clicking the links are now exact matches for the sample/case id

Review

  • Tests executed by BSV
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Deploy this branch in production

@beatrizsavinhas beatrizsavinhas requested a review from a team as a code owner February 12, 2025 13:30
@beatrizsavinhas beatrizsavinhas marked this pull request as draft February 12, 2025 13:30
@beatrizsavinhas
Copy link
Contributor Author

beatrizsavinhas commented Feb 13, 2025

Tests

Clicking STG15809A2 in the Sample table:

  • Before patch:
Screenshot 2025-02-13 at 13 51 18
  • After patch:
Screenshot 2025-02-13 at 15 42 23

Clicking adjustedkit in the Case table:

  • Before patch:
Screenshot 2025-02-13 at 13 50 08
  • After patch:
Screenshot 2025-02-13 at 15 40 48

Clicking the links in the Case Sample table:

Sample

  • Before patch:
Screenshot 2025-02-13 at 15 51 11
  • After patch:
Screenshot 2025-02-13 at 15 44 10

Case

  • Before patch:
Screenshot 2025-02-13 at 15 52 22
  • After patch:
Screenshot 2025-02-13 at 15 40 01

@beatrizsavinhas beatrizsavinhas marked this pull request as ready for review February 13, 2025 14:47
@diitaz93 diitaz93 self-requested a review February 13, 2025 14:50
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 Super nice!

Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@beatrizsavinhas beatrizsavinhas merged commit edf06af into master Feb 17, 2025
10 checks passed
@beatrizsavinhas beatrizsavinhas deleted the 3998-exact-matches-for-links-in-sample-and-case-tables branch February 17, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking links in statusdb should look for exact matches
3 participants