Bug raredisease delivery report tags #4200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diitaz93
reviewed
Feb 18, 2025
Co-authored-by: Sebastian Diaz <juan.sebastian.diaz.boada@scilifelab.se>
* test fix * made the tags literals to test
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a mismatch between old mip-dna tags and new raredisease tags when generating the upload report. cg is looking for snv_vcf and sv_vcf housekeeper tags, while the new tags are different. Furthermore, we need an exact match, as tags are shared between files, the difference in file recognition being other tags that accompany the file as well.
In the screen shot below you see only two files mentioned while it should be 4. Furthermore one of the files is a sample files, not the case file.
This does not affect what is uploaded to scout, or what is stored in housekeeper, this only affects the mentioning of the file names in the delivery report html file.
For the reviewer: the solution in this PR is to do exact matching of all tags accompanying a file.
Added
Changed
Fixed
How to prepare for test
uspaxaHow to test
cg generate delivery-report amusingmarmosetExpected test outcome
cg generate delivery-report amusingmarmosetshould complete without errorReview
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan