Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hermes): refactor to workflow in CLI call #2911

Merged
merged 3 commits into from
Feb 8, 2024
Merged

feat(hermes): refactor to workflow in CLI call #2911

merged 3 commits into from
Feb 8, 2024

Conversation

henrikstranneheim
Copy link
Contributor

@henrikstranneheim henrikstranneheim commented Feb 6, 2024 •
edited
Loading

Description

Added

Changed

  • Refactor to workflow in CLI call

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta): 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b refactor-hermes-cli -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@henrikstranneheim henrikstranneheim self-assigned this Feb 6, 2024
@henrikstranneheim henrikstranneheim requested a review from a team as a code owner February 6, 2024 11:48
@henrikstranneheim henrikstranneheim mentioned this pull request Feb 6, 2024
Merged
15 tasks
diitaz93
diitaz93 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@henrikstranneheim henrikstranneheim merged commit be1c667 into master Feb 8, 2024
9 checks passed
@henrikstranneheim henrikstranneheim deleted the refactor-hermes-cli branch February 8, 2024 07:30
@henrikstranneheim
Copy link
Contributor Author

Deployed to production:

Log deploy... done.
cg, version 57.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diitaz93 diitaz93 diitaz93 approved these changes

Assignees

@henrikstranneheim henrikstranneheim

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrikstranneheim @diitaz93