Simplify and fix UB in boot API #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove UB `boot_async` method - rename `boot` to `run` method - add back the old but now unsafe `boot` method - add migration guide from 0.4 to 0.5 #202
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
==========================================
- Coverage 76.96% 76.92% -0.05%
==========================================
Files 16 16
Lines 3052 3059 +7
==========================================
+ Hits 2349 2353 +4
- Misses 703 706 +3
Continue to review full report at Codecov.
|
added 3 commits
September 18, 2020 00:56
Restore 0.4 recommanded boot sequence but wrapped in an unsafe block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boot_asyncmethodboottorunmethodbootmethod#202