Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client info specification implementation #876

Merged
merged 12 commits into from
Jan 27, 2023
Merged

Client info specification implementation #876

merged 12 commits into from
Jan 27, 2023

Conversation

jkaflik
Copy link
Contributor

@jkaflik jkaflik commented Jan 23, 2023 •
edited
Loading

Implement client info specification with an API to provide user's products

mshustov
mshustov reviewed Jan 24, 2023
View reviewed changes
@mshustov
Copy link
Member

how are you going to provide database/sql API usage in the client info? database/sql clickhouse-go/2.5.1... or clickhouse-go/2.5.1 (api:database/sql....) ?

@jkaflik
Copy link
Contributor Author

jkaflik commented Jan 24, 2023 •
edited
Loading

how are you going to provide database/sql API usage in the client info? database/sql clickhouse-go/2.5.1... or clickhouse-go/2.5.1 (api:database/sql....) ?

I think providing it in bracket is a better option.

@mshustov
Copy link
Member

I think providing it in bracket is a better option.

Will you add it (along with the tests) to the current PR?

@jkaflik
Copy link
Contributor Author

jkaflik commented Jan 24, 2023

Yes. Please keep in mind this PR is draft.

mshustov
mshustov reviewed Jan 24, 2023
View reviewed changes
@jkaflik jkaflik marked this pull request as ready for review January 24, 2023 17:40
@jkaflik jkaflik merged commit 61b30f3 into main Jan 27, 2023
@mshustov mshustov deleted the clientinfo branch January 27, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshustov mshustov mshustov approved these changes

@genzgd genzgd Awaiting requested review from genzgd

@mzitnik mzitnik Awaiting requested review from mzitnik

@slvrtrn slvrtrn Awaiting requested review from slvrtrn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkaflik @mshustov