Exception fix #1481
Closed
Exception fix #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
e9f78bb to
01c1d99
Compare
|
Hello! Thank you for submitting this PR. It looks like this code would work for some cases, however I don't think it would be performant to do multiple regexes for every query exec. Ultimately this needs to be solved at the server level. We have an issue open discussing it here: ClickHouse/ClickHouse#75175 Depending on the server-side fix, some code in this PR may be relevant again, but for now I will close it. I appreciate you looking into this though, if you have any suggestions on how to improve the error detection please leave a comment on the linked issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added exception handling while executing query
#1468
Checklist